Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FullRange Hook Bug Fixes #128

Closed
wants to merge 3 commits into from
Closed

FullRange Hook Bug Fixes #128

wants to merge 3 commits into from

Conversation

Jun1on
Copy link
Contributor

@Jun1on Jun1on commented Jun 24, 2024 •
edited
Loading

Related Issue

  1. someone can externally call beforeInitialize and overwrite the poolToken
  2. function _rebalance is public
  3. fees can easily be yoinked

Description of changes

  1. add onlyByManager
  2. rename _rebalance -> rebalance
  3. rebalance before add liquidity and mint the user the proportional of liquidity*totalSupply/getLiquidity(poolId) instead of liquidity

@Jun1on Jun1on linked an issue Jun 24, 2024 that may be closed by this pull request
[Bug]: FullRange missing access controls (security bug) #71
Closed
@Jun1on Jun1on marked this pull request as draft June 24, 2024 18:22
@Jun1on Jun1on linked an issue Jun 24, 2024 that may be closed by this pull request
[Bug]: FullRange.addLiquidity: wrong amount of tokens minted #68
Closed
@Jun1on Jun1on changed the title FullRange access control FullRange Hook Bug Fixes Jun 24, 2024
@Jun1on Jun1on removed a link to an issue Jun 24, 2024
[Bug]: FullRange.addLiquidity: wrong amount of tokens minted #68
Closed
This was linked to issues Jun 24, 2024
[Bug]: FullRange.addLiquidity: wrong amount of tokens minted #68
Closed
[Bug]: access modifier should be internal for _rebalance in the FullRange example (security related) #79
Closed
@Jun1on Jun1on marked this pull request as ready for review June 26, 2024 14:49
@saucepoint saucepoint added the revisit issues that were closed prior to cantina, but may be revisited label Jan 9, 2025
@saucepoint
Copy link
Collaborator

we arent providing example hooks at this time; but added a revisit tag if that were to change in the future!

@saucepoint saucepoint closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Example contracts repo improvement revisit issues that were closed prior to cantina, but may be revisited
Projects
None yet
Milestone
No milestone
3 participants
@Jun1on @saucepoint @hensha256